mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 63385: Added utility functions for CSI Plugin info and volume attributes.
Date Sun, 26 Nov 2017 23:10:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63385/
-----------------------------------------------------------

(Updated Nov. 26, 2017, 11:10 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Addressed jieyu's comments and added a test.


Repository: mesos


Description
-------

Added utility functions for CSI Plugin info and volume attributes.


Diffs (updated)
-----

  src/common/protobuf_utils.hpp eff106f0a546f459030d5cf5b42e5eb8d4d9a34c 
  src/common/protobuf_utils.cpp a5fc960b8387342eba4c66a711fedc92dd014e6f 
  src/csi/utils.hpp PRE-CREATION 
  src/csi/utils.cpp PRE-CREATION 
  src/tests/protobuf_utils_tests.cpp 2be26a5f467be85ec0ad28dcd8202e603e4a9d5e 


Diff: https://reviews.apache.org/r/63385/diff/3/

Changes: https://reviews.apache.org/r/63385/diff/2-3/


Testing
-------

make


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message