mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63823: Initialization and registration for storage local resource provider.
Date Sun, 26 Nov 2017 04:49:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63823/#review191858
-----------------------------------------------------------




src/resource_provider/manager.cpp
Lines 393-395 (original), 393-399 (patched)
<https://reviews.apache.org/r/63823/#comment269794>

    Hum, we need a proper resubscription impl here. Looks like Jan is working on that here:
    https://reviews.apache.org/r/64065
    
    I'll review that patch first and let's consolidate it.



src/resource_provider/storage/provider.cpp
Lines 276 (patched)
<https://reviews.apache.org/r/63823/#comment269797>

    Can you add a TODO here to do exponential backoff here?



src/resource_provider/storage/provider.cpp
Lines 294 (patched)
<https://reviews.apache.org/r/63823/#comment269798>

    Can you add some CHECK here (e.g., the current state should be CONNECTED). Ditto on other
places.


- Jie Yu


On Nov. 22, 2017, 8:47 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63823/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2017, 8:47 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8032
>     https://issues.apache.org/jira/browse/MESOS-8032
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch validates `ResourceProviderInfo` for storage local resource
> providers upon creation. During initialization, the storage local
> resource provider first tries to recover its ID of the last session
> through reading the actual path linked by
> `<work_dir>/meta/resource_providers/<type>/<name>/latest`,
> then do a reliable registration to the agent's resource provider
> manager.
> 
> This patch is split from https://reviews.apache.org/r/63021/.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp 6dfc42900a1e4249f37cec585f7fe50f5aa94e43 
>   src/resource_provider/storage/provider.cpp 46224997430ac0c568904d80014166a6f059907f

> 
> 
> Diff: https://reviews.apache.org/r/63823/diff/3/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message