mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 63904: Updated the top-level `CSIPluginInfo` proto.
Date Thu, 23 Nov 2017 09:47:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63904/
-----------------------------------------------------------

(Updated Nov. 23, 2017, 9:47 a.m.)


Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, Joseph Wu, and Jan Schlicht.


Changes
-------

Addressed jieyu's comment.


Bugs: MESOS-7561
    https://issues.apache.org/jira/browse/MESOS-7561


Repository: mesos


Description
-------

The `type` and `name` fields are introduced to uniquely identify a CSI
service bundle. The purpose of the new proto and these two fields is to
decouple a CSI service bundle from a `ResoruceProviderInfo`, so we may
allow tasks to directly use non-resource volumes (such as NFS volumes).


Diffs (updated)
-----

  include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435 
  include/mesos/type_utils.hpp f7f23270fadc75a8737f32ec1c3fbc01f6321248 
  include/mesos/v1/mesos.hpp 26b4596024f4da987e73efb1cfc03ff97bd2fc5d 
  include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e 
  src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc 
  src/v1/mesos.cpp 44767b1f87ff5d858df890ef75c77736ba969f94 


Diff: https://reviews.apache.org/r/63904/diff/4/

Changes: https://reviews.apache.org/r/63904/diff/3-4/


Testing
-------

make


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message