mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.
Date Wed, 22 Nov 2017 12:16:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63795/#review191722
-----------------------------------------------------------




src/checks/tcp_connect.cpp
Lines 90 (patched)
<https://reviews.apache.org/r/63795/#comment269606>

    Should have bought this up earlier. I think this code will be a lot more simpler if you
use `network::Address` to represent the ip:port address.
    https://github.com/apache/mesos/blob/master/3rdparty/libprocess/include/process/address.hpp#L277
    
    You wouldn't need to maintain family specific code here and you can directly use the 
    `sock_storage` cast operator
    https://github.com/apache/mesos/blob/master/3rdparty/libprocess/include/process/address.hpp#L377


- Avinash sridharan


On Nov. 17, 2017, 12:57 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63795/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2017, 12:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Avinash sridharan.
> 
> 
> Bugs: MESOS-8050
>     https://issues.apache.org/jira/browse/MESOS-8050
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made `mesos-tcp-connect` support IPv6.
> 
> 
> Diffs
> -----
> 
>   src/checks/tcp_connect.cpp 2514f4aebcc634b18cd2b3c36529222fe456e903 
> 
> 
> Diff: https://reviews.apache.org/r/63795/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message