mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 64010: Added new overload for reviveOffers to allocator API.
Date Wed, 22 Nov 2017 00:30:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64010/#review191682
-----------------------------------------------------------



Change the commit message to remove "overload"


include/mesos/allocator/allocator.hpp
Lines 373 (patched)
<https://reviews.apache.org/r/64010/#comment269532>

    who -> which



include/mesos/allocator/allocator.hpp
Lines 376 (patched)
<https://reviews.apache.org/r/64010/#comment269533>

    Rename to removeFilters()



src/master/allocator/mesos/hierarchical.cpp
Line 637 (original), 637 (patched)
<https://reviews.apache.org/r/64010/#comment269538>

    - Make a stronger updateSlave() that also takes SlaveInfo and other needed arguments
    - Call resetFilters() from inside updateSlave2() instead of exposing it to the world.



src/master/allocator/mesos/hierarchical.cpp
Lines 1297 (patched)
<https://reviews.apache.org/r/64010/#comment269535>

    Rename type to `Filters`.



src/master/allocator/mesos/hierarchical.cpp
Lines 1309 (patched)
<https://reviews.apache.org/r/64010/#comment269536>

    Change log message



src/master/master.cpp
Lines 6943 (patched)
<https://reviews.apache.org/r/64010/#comment269534>

    Move to later commit.


- Benno Evers


On Nov. 22, 2017, 12:11 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64010/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2017, 12:11 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The added function allows to erase all offer filter that
> were set for a given slave.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp ae122003487ca8956573e993cd3993aa8cc286f1 
>   src/master/allocator/mesos/allocator.hpp 8fa4fdeec4ec64bcd49fc442c230d8684a11cfd9 
>   src/master/allocator/mesos/hierarchical.hpp 2c4832b29842330fa57756cd3d4202f265a820f3

>   src/master/allocator/mesos/hierarchical.cpp cfeeb3bfa3ad7d78ff6e22cfc4adb1f0efa05629

>   src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f 
>   src/tests/allocator.hpp 6a84f1beb86dceb5a5e9bf4615c13a216f3d0905 
>   src/tests/hierarchical_allocator_tests.cpp f0f95ba4f667bf8ea54e985d8cde913a4170d8ff

> 
> 
> Diff: https://reviews.apache.org/r/64010/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message