mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 62635: Added an optional `additional_chars` parameter to `http::encode`.
Date Wed, 22 Nov 2017 00:08:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62635/#review191680
-----------------------------------------------------------


Ship it!




Need a unit test for this! I'll write one for you!

- Jie Yu


On Nov. 20, 2017, 11:44 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62635/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2017, 11:44 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new `additional_chars` parameter specifies the extra characters to
> be percent-encoded, in addition to the ones specified in RFC 3986.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 78cf2c36d2a332c8114941ef3831f0bc8f546c3b

>   3rdparty/libprocess/src/http.cpp eb4cd586696a569e3985739242d61f25da88cc30 
> 
> 
> Diff: https://reviews.apache.org/r/62635/diff/2/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message