mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 64007: Added master capabilities.
Date Tue, 21 Nov 2017 23:50:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64007/#review191673
-----------------------------------------------------------



- Expand commit message.
- Add test that verifies master has empty capabilities list in state.cpp
- Add new file to CMakeLists.txt


include/mesos/mesos.proto
Lines 894 (patched)
<https://reviews.apache.org/r/64007/#comment269521>

    Rename to `AGENT_UPDATE`.



include/mesos/mesos.proto
Lines 899 (patched)
<https://reviews.apache.org/r/64007/#comment269522>

    Rename to `capabilities`.



src/common/protobuf_utils.hpp
Lines 351 (patched)
<https://reviews.apache.org/r/64007/#comment269524>

    Rename bool to match changed capability name.



src/master/http.cpp
Lines 81 (patched)
<https://reviews.apache.org/r/64007/#comment269525>

    Double-check whether this is in the correct commit.



src/master/http.cpp
Line 146 (original), 147 (patched)
<https://reviews.apache.org/r/64007/#comment269526>

    Add blank lines.



src/slave/slave.cpp
Lines 95 (patched)
<https://reviews.apache.org/r/64007/#comment269527>

    Move this to a later commit.


- Benno Evers


On Nov. 21, 2017, 11:20 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64007/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2017, 11:20 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added master capabilities.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435 
>   include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e 
>   src/Makefile.am 49dec55ced32945ad0414c32eb4e00247f4b54f2 
>   src/common/protobuf_utils.hpp b2aa3654db2fe7d7d9d275ded81c6d54244654ee 
>   src/common/protobuf_utils.cpp 34054846f93f19ba550afe58e2a899d111ad38dc 
>   src/master/constants.hpp 725680b1e5f1fb9ca87ec5130d0eff72309432ae 
>   src/master/constants.cpp PRE-CREATION 
>   src/master/http.cpp 10084125deb839a9846a4f64d2e433ff02754c02 
>   src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f 
>   src/slave/slave.cpp d8edc5e6bbfa265bca4d19bbaa7db3063949dbc0 
> 
> 
> Diff: https://reviews.apache.org/r/64007/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message