-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63842/#review191664
-----------------------------------------------------------
src/master/master.hpp
Lines 2919 (patched)
<https://reviews.apache.org/r/63842/#comment269505>
`removeOfferOperation` might be used for old operations too. This will throw a CHECK failure.
- Jie Yu
On Nov. 21, 2017, 10:11 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63842/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2017, 10:11 p.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> During reconcilation we might be required to remove non-terminal offer
> operations from bookkeeping.
>
>
> Diffs
> -----
>
> src/master/master.hpp 2a2e830354db4a2191fb8321beb8174b80f7ba7d
> src/master/master.cpp 7417b5d641fd4bb6d91cb0e6456c60201bbc8206
> src/slave/slave.cpp 6e9adc60f593faf1b0e56caeea04882f67af7080
>
>
> Diff: https://reviews.apache.org/r/63842/diff/4/
>
>
> Testing
> -------
>
> `make check`, tested as part of https://reviews.apache.org/r/63843/.
>
> This patch requires `protobuf::isSpeculativeOperation` from https://reviews.apache.org/r/63751/
which is _not_ part of this review chain (to avoid multiple dependent RRs).
>
>
> Thanks,
>
> Benjamin Bannier
>
>
|