mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <>
Subject Re: Review Request 63842: Allowed removing non-terminal offer operations.
Date Tue, 21 Nov 2017 22:11:59 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 21, 2017, 11:11 p.m.)

Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.


Did not count speculative operations as `used`.

Repository: mesos


During reconcilation we might be required to remove non-terminal offer
operations from bookkeeping.

Diffs (updated)

  src/master/master.hpp 2a2e830354db4a2191fb8321beb8174b80f7ba7d 
  src/master/master.cpp 7417b5d641fd4bb6d91cb0e6456c60201bbc8206 
  src/slave/slave.cpp 6e9adc60f593faf1b0e56caeea04882f67af7080 



Testing (updated)

`make check`, tested as part of

This patch requires `protobuf::isSpeculativeOperation` from
which is _not_ part of this review chain (to avoid multiple dependent RRs).


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message