mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 63732: Reconciled offer operations between agent and master.
Date Tue, 21 Nov 2017 21:11:17 GMT


> On Nov. 18, 2017, 2 a.m., Jie Yu wrote:
> > src/master/master.cpp
> > Lines 7119 (patched)
> > <https://reviews.apache.org/r/63732/diff/3/?file=1896906#file1896906line7125>
> >
> >     If the LRP is not yet re-registered with the agent, we shouldn't remove the
offer operation. We should only remove those operation that we know "for sure" is gone.

See my comment here, https://reviews.apache.org/r/63732/#comment268753.


> On Nov. 18, 2017, 2 a.m., Jie Yu wrote:
> > src/master/master.cpp
> > Lines 7126 (patched)
> > <https://reviews.apache.org/r/63732/diff/3/?file=1896906#file1896906line7132>
> >
> >     If you can `updateOfferOperation`, then allocator's state will be updated accordingly.

I don't think `updateOffer` is the correct method to use here. We can either use `recoverResources`
to remove disappeared offer operations, or the newly added `addAllocation` to inform the allocator
about existing allocations.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63732/#review191427
-----------------------------------------------------------


On Nov. 21, 2017, 10:09 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63732/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2017, 10:09 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8207
>     https://issues.apache.org/jira/browse/MESOS-8207
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 7417b5d641fd4bb6d91cb0e6456c60201bbc8206 
> 
> 
> Diff: https://reviews.apache.org/r/63732/diff/4/
> 
> 
> Testing
> -------
> 
> `make check`, tested as part of https://reviews.apache.org/r/63843/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message