mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Review Request 64001: Made sure all true allocator agent updates return correct status.
Date Tue, 21 Nov 2017 21:10:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64001/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

The allocator method 'updateSlave' can be used to modify either an
agent's capabilities, its total resources, or both. It is expected
that this method return 'true' whenever a change occurred.

This patch fixes an issue where if the method as implemented in the
hierarchical allocator was called with new capabilities but the
current total resources, 'false' would have been returned, even though
the capabilities where updated.


Diffs
-----

  src/master/allocator/mesos/hierarchical.cpp cfeeb3bfa3ad7d78ff6e22cfc4adb1f0efa05629 


Diff: https://reviews.apache.org/r/64001/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message