mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 63917: Renamed resource provider message UpdateTotalResources to UpdateState.
Date Tue, 21 Nov 2017 21:08:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63917/
-----------------------------------------------------------

(Updated Nov. 21, 2017, 10:08 p.m.)


Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.


Changes
-------

Addressed Jie's comment.


Repository: mesos


Description
-------

This message now captures much more than just resource updates, but
instead informs users about the full resource provider state. This
change mirrors the message naming used between resource provider
manager and resource providers.


Diffs (updated)
-----

  src/resource_provider/manager.cpp 6dfc42900a1e4249f37cec585f7fe50f5aa94e43 
  src/resource_provider/message.hpp 05879cdc01dca88440ce89beb487168c033fab37 
  src/slave/slave.cpp 6e9adc60f593faf1b0e56caeea04882f67af7080 
  src/tests/resource_provider_manager_tests.cpp ecfe2b4c0952838d6312df603f8eb2f458725175 


Diff: https://reviews.apache.org/r/63917/diff/2/

Changes: https://reviews.apache.org/r/63917/diff/1-2/


Testing (updated)
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message