mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 63984: Fixed build dependencies in libprocess.
Date Tue, 21 Nov 2017 19:50:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63984/#review191628
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On Nov. 21, 2017, 3:15 p.m., Dmitry Zhuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63984/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2017, 3:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Sometimes `libprocess` can fail to build due to missing protobuf files.
> This adds protobufs to `BUILT_SOURCES` to ensure they are generated
> before other files are compiled.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am 896be0c6fd2cca514a226f861574e37f89befa1e 
> 
> 
> Diff: https://reviews.apache.org/r/63984/diff/2/
> 
> 
> Testing
> -------
> 
> rm -r build
> mkdir build
> cd build
> ../configure
> make check
> 
> 
> Thanks,
> 
> Dmitry Zhuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message