mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 63959: Optimized resources logging and conversion in master.
Date Tue, 21 Nov 2017 18:16:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63959/#review191614
-----------------------------------------------------------



Thanks! Could you split the patch between the logging performance improvements and the other
changes?

I was a little unclear on some of the other ones (e.g. will `Resources::+=(const RepeatedPtrField&)`
generate an implicit conversion, or?)


src/master/master.cpp
Lines 6255-6256 (original), 6255-6256 (patched)
<https://reviews.apache.org/r/63959/#comment269457>

    A comment here for posterity would be helpful, about the performance impliciations. Ditto
below.


- Benjamin Mahler


On Nov. 20, 2017, 4:51 p.m., Dmitry Zhuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63959/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2017, 4:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When master logs agent or task resources, it uses `operator <<` for raw
> protobuf data, which outputs resources in JSON format, and is rather
> slow. However resources are known to be valid and refined when logged by
> master, so it's faster to use `operator <<` after protobuf is converted
> to `Resources`.
> This patch also factors out implicit conversions to `Resources` to avoid
> multiple conversions.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3 
>   src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f 
> 
> 
> Diff: https://reviews.apache.org/r/63959/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dmitry Zhuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message