mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 63960: Preallocated buffer for resources conversion.
Date Tue, 21 Nov 2017 18:11:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63960/#review191612
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On Nov. 20, 2017, 5:20 p.m., Dmitry Zhuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63960/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2017, 5:20 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When converting collections of protobuf `Resource` to `Resources`,
> `std::vector` could be resized several times. This patch ensures that
> there is enough capacity to fit all resources in `vector` and avoid
> resizes.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 4ccfdc162c8e875a4c37b81123a4f61fccdda5e6 
> 
> 
> Diff: https://reviews.apache.org/r/63960/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dmitry Zhuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message