mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.
Date Tue, 21 Nov 2017 18:04:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63741/#review191605
-----------------------------------------------------------




src/internal/devolve.cpp
Lines 194-196 (original), 194-196 (patched)
<https://reviews.apache.org/r/63741/#comment269449>

    What about `evolve()`?



src/internal/devolve.cpp
Lines 199-200 (patched)
<https://reviews.apache.org/r/63741/#comment269454>

    Maybe a simple `if(){}` for now? Maybe the next special case will not be type dependent?



src/internal/devolve.cpp
Lines 203-204 (patched)
<https://reviews.apache.org/r/63741/#comment269453>

    I believe we prefer writing `CopyFrom()` explicitly, no?


- Alexander Rukletsov


On Nov. 15, 2017, 6:41 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63741/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2017, 6:41 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8200
>     https://issues.apache.org/jira/browse/MESOS-8200
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also improved logging to show the suppressed roles.
> 
> 
> Diffs
> -----
> 
>   src/internal/devolve.cpp 3a02490d734ef4a558b448871f9a1054d832f457 
>   src/master/master.cpp 81192d5ce7c095495a5faa534d4792601e540e0e 
> 
> 
> Diff: https://reviews.apache.org/r/63741/diff/1/
> 
> 
> Testing
> -------
> 
> Tested together with /r/63830/.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message