mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 63904: Updated the top-level `CSIPluginInfo` proto.
Date Tue, 21 Nov 2017 05:32:40 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 21, 2017, 5:32 a.m.)

Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, Joseph Wu, and Jan Schlicht.


Addressed jdef's comments. Removed unused `operator!=` for `ResourceProviderInfo`. The equality
operator will be used in unit tests down in the chain.

Summary (updated)

Updated the top-level `CSIPluginInfo` proto.

Bugs: MESOS-7561

Repository: mesos

Description (updated)

The `type` and `name` fields are introduced to uniquely identify a CSI
service bundle. The purpose of the new proto and these two fields is to
decouple a CSI service bundle from a `ResoruceProviderInfo`, so we may
allow tasks to directly use non-resource volumes (such as NFS volumes).

Diffs (updated)

  include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435 
  include/mesos/type_utils.hpp f7f23270fadc75a8737f32ec1c3fbc01f6321248 
  include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e 
  src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc 



Testing (updated)



Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message