mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 63967: Updated the gRPC client to return both status and payload.
Date Tue, 21 Nov 2017 00:36:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63967/#review191552
-----------------------------------------------------------


Ship it!




Ship It!

- Chun-Hung Hsiao


On Nov. 20, 2017, 10:42 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63967/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2017, 10:42 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some user might want to perform differently based on the error code in
> the gRPC Status. This patch exposes the gRPC Status by introducing a
> struct called `RpcResult` which contains both the gRPC Status and the
> response body.
> 
> Note that gRPC allows gRPC Status to be non-OK and still has a response
> body.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/grpc.hpp f5dc8b51bda45c40744d838defefe704cb7b4a7d

>   3rdparty/libprocess/src/tests/grpc_tests.cpp 7ac4ef6ebca84197379a2b8e91563600c1e10273

> 
> 
> Diff: https://reviews.apache.org/r/63967/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message