mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 62635: Added an optional `additional_chars` parameter to `http::encode`.
Date Mon, 20 Nov 2017 23:44:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62635/
-----------------------------------------------------------

(Updated Nov. 20, 2017, 11:44 p.m.)


Review request for mesos, Greg Mann, Jie Yu, and Joseph Wu.


Changes
-------

Addressed kaysoky's comments.


Summary (updated)
-----------------

Added an optional `additional_chars` parameter to `http::encode`.


Repository: mesos


Description (updated)
-------

The new `additional_chars` parameter specifies the extra characters to
be percent-encoded, in addition to the ones specified in RFC 3986.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/http.hpp 78cf2c36d2a332c8114941ef3831f0bc8f546c3b 
  3rdparty/libprocess/src/http.cpp eb4cd586696a569e3985739242d61f25da88cc30 


Diff: https://reviews.apache.org/r/62635/diff/2/

Changes: https://reviews.apache.org/r/62635/diff/1-2/


Testing
-------

make


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message