mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 63860: Windows: Mapped the Docker network info types.
Date Fri, 17 Nov 2017 22:38:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63860/
-----------------------------------------------------------

(Updated Nov. 17, 2017, 10:37 p.m.)


Review request for mesos, Andrew Schwartzmeyer and John Kordich.


Summary (updated)
-----------------

Windows: Mapped the Docker network info types.


Bugs: MESOS-7342
    https://issues.apache.org/jira/browse/MESOS-7342


Repository: mesos


Description
-------

The current Network enum in DockerInfo is specific to Linux containers.
Instead of supporting {host, bridge, none, user} networks, Windows
docker supports {nat, none, user} networks. Now, if the host network
type is sent to the Windows agent, it will return an error. If the
bridge network is sent, then it will be internally converted to nat,
since they are equivalent.


Diffs (updated)
-----

  src/docker/docker.cpp 722a54ad113fc4e2bb22a8f08e307ab38d5fbfed 


Diff: https://reviews.apache.org/r/63860/diff/2/

Changes: https://reviews.apache.org/r/63860/diff/1-2/


Testing
-------

See https://reviews.apache.org/r/63862/ for test results.


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message