mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 63861: Updated networking doc for Windows docker containers.
Date Fri, 17 Nov 2017 21:43:48 GMT


> On Nov. 16, 2017, 6:46 p.m., Andrew Schwartzmeyer wrote:
> > docs/networking.md
> > Lines 118-123 (patched)
> > <https://reviews.apache.org/r/63861/diff/1/?file=1893973#file1893973line118>
> >
> >     Are the names of the network types on Windows generally capitalized (like the
Linux ones here are)?

Neither are capitialized. The `BRIDGE`, `HOST`, etc are captialized enums in the `Network`
protobuf, so that's why I capitialized them.


- Akash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/#review191218
-----------------------------------------------------------


On Nov. 16, 2017, 6:18 p.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63861/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2017, 6:18 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
> 
> 
> Bugs: MESOS-7342
>     https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated networking doc for Windows docker containers.
> 
> 
> Diffs
> -----
> 
>   docs/networking.md bdd3a762435aae163fc659cc0000fea7da825983 
> 
> 
> Diff: https://reviews.apache.org/r/63861/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message