mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 63842: Allowed removing non-terminal offer operations.
Date Fri, 17 Nov 2017 17:24:37 GMT


> On Nov. 15, 2017, 10:05 p.m., Jie Yu wrote:
> > src/master/master.cpp
> > Lines 9816-9817 (original)
> > <https://reviews.apache.org/r/63842/diff/1/?file=1893482#file1893482line9816>
> >
> >     If you remove this CHECK, i'd like to see the resoures used by the operation
being released. For instance, if a new operation is in non terminal status, you want to release
the resources that it currently uses when removing the operation. That ensures that we don't
leak any resources.

I added cleanup code for `usedResources` matching what is done in `Slave::addOfferOperation`.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63842/#review191104
-----------------------------------------------------------


On Nov. 17, 2017, 6:24 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63842/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2017, 6:24 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> During reconcilation we might be required to remove non-terminal offer
> operations from bookkeeping.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3 
>   src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f 
>   src/slave/slave.cpp d8edc5e6bbfa265bca4d19bbaa7db3063949dbc0 
> 
> 
> Diff: https://reviews.apache.org/r/63842/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message