mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.
Date Fri, 17 Nov 2017 02:07:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56721/#review191286
-----------------------------------------------------------




src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp
Lines 107 (patched)
<https://reviews.apache.org/r/56721/#comment269056>

    could you do a grep and fix the excludedImages naming in
    
    metadata_manager.cpp:
    provisioner/docker/store.cpp:
    mesos_containerizer_tests.cpp:
    provisioner_docker_tests.cpp:



src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 469 (patched)
<https://reviews.apache.org/r/56721/#comment269047>

    you dont need `this` for this lambda



src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 461-462 (original), 476-478 (patched)
<https://reviews.apache.org/r/56721/#comment269048>

    make them oneline?



src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 487 (patched)
<https://reviews.apache.org/r/56721/#comment269049>

    this is not safe! you need to defer self.



src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 556 (patched)
<https://reviews.apache.org/r/56721/#comment269051>

    ditto.



src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 599 (patched)
<https://reviews.apache.org/r/56721/#comment269052>

    ditto



src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 698 (patched)
<https://reviews.apache.org/r/56721/#comment269053>

    ditto.



src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 737 (patched)
<https://reviews.apache.org/r/56721/#comment269055>

    why do you need defer here?



src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 739 (patched)
<https://reviews.apache.org/r/56721/#comment269054>

    ditto


- Gilbert Song


On Nov. 15, 2017, 8 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56721/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2017, 8 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-4945
>     https://issues.apache.org/jira/browse/MESOS-4945
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This includes the following changes:
> - add a `pruneImages()` function on the chain of relevant classes;
> - implement prune in docker store;
> - fix mock interface to keep existing tests pass.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/composing.hpp c2689cf36575d1e7c6ef8bd2ab3e25681a2ecfcc 
>   src/slave/containerizer/composing.cpp 64919ef1e61a984956c2280ae6b1890c4d135ad1 
>   src/slave/containerizer/containerizer.hpp 2027bd93cc439ed9b2f544e57183765ee032603b

>   src/slave/containerizer/docker.hpp 105c0680b6714aded1b3e05699930a072545e681 
>   src/slave/containerizer/docker.cpp 63432a99f58aab00cd8612164e00fe6c3a6cf5dd 
>   src/slave/containerizer/mesos/containerizer.hpp f5d5146de9abdd9804ede6a4b17a965a4b27c05a

>   src/slave/containerizer/mesos/containerizer.cpp db5f044f7415386c94e4930f365dfc14d403414a

>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb

>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab

>   src/slave/containerizer/mesos/provisioner/docker/paths.hpp 232c027f8f96da0cb30b957bce4607d3695050d2

>   src/slave/containerizer/mesos/provisioner/docker/paths.cpp cd684b33eb308ce1eeb4539a5b2d51985d835db7

>   src/slave/containerizer/mesos/provisioner/docker/store.hpp 1cf68665d33bd40a7605d26c96fb7b618407fdd0

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp f357710cb19aec3654b0604f7909d068eaf20095

>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 7cba54ce490d1e6e17081cd7e04fd6759ceddb8e

>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 450a3b32d69d2882973a6ed4e94e169a0256056b

>   src/slave/containerizer/mesos/provisioner/store.hpp 01ab83dca79e51b8c96d18ee65705912b0ac8324

>   src/slave/containerizer/mesos/provisioner/store.cpp cc5cc81e05f29bb0e11ffa13cdb8d63d4397114f

>   src/tests/containerizer.hpp c98913f1a833aa6a60779b66463610ccd5911bbf 
>   src/tests/containerizer.cpp c6f1ec0b000781270b7c79d5e776575c6df778aa 
>   src/tests/containerizer/mock_containerizer.hpp 5befcccecdb76f3b70993642128745a0134ffa65

> 
> 
> Diff: https://reviews.apache.org/r/56721/diff/17/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message