mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 62636: Generated authentication tokens for local resource providers.
Date Fri, 17 Nov 2017 00:19:19 GMT


> On Nov. 7, 2017, 2:30 a.m., Joseph Wu wrote:
> > src/resource_provider/daemon.cpp
> > Lines 96-99 (original), 114-118 (patched)
> > <https://reviews.apache.org/r/62636/diff/5/?file=1880935#file1880935line114>
> >
> >     I'd consider an error at this step to be a fatal error (basically a misconfiguration),
so we should fail-fast here and exit the agent.

Fixed in r63376.


> On Nov. 7, 2017, 2:30 a.m., Joseph Wu wrote:
> > src/slave/slave.cpp
> > Line 1234 (original), 1234-1236 (patched)
> > <https://reviews.apache.org/r/62636/diff/5/?file=1880936#file1880936line1234>
> >
> >     Consider moving this comment above `start` in `daemon.hpp`.  (With the side
benefit of not needing to duplicate the comment in two places)

Done. This makes sense to me, as the caller would go to the header file to check why we need
this argument.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62636/#review190257
-----------------------------------------------------------


On Nov. 17, 2017, 12:19 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62636/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2017, 12:19 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Greg Mann, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8100
>     https://issues.apache.org/jira/browse/MESOS-8100
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `LocalResourceProviderDaemon` now uses `Slave::secretGenerater` to
> generate an authentication token for each local resource provider. The
> authentication token can then be used to call the V1 agent API. In order
> to generate the tokens, `LocalResourceProviderDaemon::load()` is now an
> asynchronous function.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/daemon.hpp ef6c356cb6ddb2594d767d7dd6052e9fd8df8263 
>   src/resource_provider/daemon.cpp d584eb9d7aa75522aec97277674321061b90fbed 
>   src/slave/slave.cpp d8edc5e6bbfa265bca4d19bbaa7db3063949dbc0 
> 
> 
> Diff: https://reviews.apache.org/r/62636/diff/6/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message