mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 63376: Started `LocalResourceProviderDaemon` after obtaining the slave ID.
Date Fri, 17 Nov 2017 00:13:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63376/
-----------------------------------------------------------

(Updated Nov. 17, 2017, 12:13 a.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, Joseph Wu, and Jan Schlicht.


Changes
-------

Constructed the process object during daemon creation but spawned it later when `start()`
is called. This enables us to accept reload requests even before `start()` is called by the
agent. Also made the daemon fail-fast if the config dir cannot be read.


Bugs: MESOS-8097
    https://issues.apache.org/jira/browse/MESOS-8097


Repository: mesos


Description (updated)
-------

The local resource provider daemon is now started aftor we get a slave
id (either through registration or recovery). The slave id will be
eventually passed into each local resource provider for checkpointing
their metadata.


Diffs (updated)
-----

  src/resource_provider/daemon.hpp ef6c356cb6ddb2594d767d7dd6052e9fd8df8263 
  src/resource_provider/daemon.cpp d584eb9d7aa75522aec97277674321061b90fbed 
  src/slave/slave.cpp d8edc5e6bbfa265bca4d19bbaa7db3063949dbc0 


Diff: https://reviews.apache.org/r/63376/diff/2/

Changes: https://reviews.apache.org/r/63376/diff/1-2/


Testing
-------

make


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message