mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 63852: Added "Task" prefix to status update manager related classes/methods.
Date Thu, 16 Nov 2017 23:23:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63852/
-----------------------------------------------------------

(Updated Nov. 16, 2017, 3:23 p.m.)


Review request for mesos and Greg Mann.


Changes
-------

Updated comments.


Bugs: MESOS-8197
    https://issues.apache.org/jira/browse/MESOS-8197


Repository: mesos


Description
-------

We're about to add an offer operation status update manager and a
generic `StatusUpdateManagerProcess` class, which would conflict with
the name of the current classes/methods/variables.


Diffs (updated)
-----

  src/local/local.cpp 99c1b087d75a1759ed61a4e6178e15919bee1e77 
  src/messages/messages.proto 33732e28d087a17080eb9aa7d9a91c367172be7f 
  src/slave/main.cpp 94431b036524ef4db16a594c80f45b64a45728f7 
  src/slave/slave.hpp 40442f25ae1b223380e11f8602e6256c9203ef47 
  src/slave/slave.cpp d8edc5e6bbfa265bca4d19bbaa7db3063949dbc0 
  src/slave/status_update_manager.hpp 14ead42f22e342d03c117eabe7af635b48052703 
  src/slave/status_update_manager.cpp e0d029b855de1024882a0db3c2556523240179e5 
  src/tests/api_tests.cpp c9c50b91ddd7c3317c1188f878753ad3bd5c3941 
  src/tests/cluster.hpp 65634121b7fe076a7cd9a1c5aa6101a96b1c009d 
  src/tests/cluster.cpp d657da6d84e5ea28e0dad180dce069de569c5d38 
  src/tests/master_slave_reconciliation_tests.cpp 6acf694538c61ce46e513b7b2805da0e0f7758dc

  src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b 
  src/tests/mock_slave.hpp 57189cee20511d145ae6b47a4dc2c66a14638dad 
  src/tests/mock_slave.cpp db24f9e5b71f558d2f811f0da8a9cc9c7c2dd341 
  src/tests/reconciliation_tests.cpp 8c43ffd1cd4ffe1b11d67eb0a1f768c736826d91 
  src/tests/slave_recovery_tests.cpp c864aa92d9ff128a89dbc25653385de25653f56a 
  src/tests/slave_tests.cpp a75bb260df223b5b86f31e91eec1b6ba8db00cb2 
  src/tests/status_update_manager_tests.cpp 24d6a9951b164369b2a5875e1c54b7e69e22d66b 


Diff: https://reviews.apache.org/r/63852/diff/2/

Changes: https://reviews.apache.org/r/63852/diff/1-2/


Testing
-------

Tests still pass on GNU/Linux.


Thanks,

Gaston Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message