mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.
Date Thu, 16 Nov 2017 22:27:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63680/#review191257
-----------------------------------------------------------




src/slave/container_daemon.cpp
Lines 50-61 (patched)
<https://reviews.apache.org/r/63680/#comment268981>

    Hum, so we assume v1 uses token based authentication? What if agent API uses basic authn?



src/slave/container_daemon.cpp
Lines 157 (patched)
<https://reviews.apache.org/r/63680/#comment268982>

    i'd rename this to `launch`, and rename stop to `wait`



src/slave/container_daemon.cpp
Lines 166 (patched)
<https://reviews.apache.org/r/63680/#comment268979>

    `response.status != http::Status::OK`



src/slave/container_daemon.cpp
Lines 195-196 (patched)
<https://reviews.apache.org/r/63680/#comment268980>

    Ditto.


- Jie Yu


On Nov. 16, 2017, 9:27 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63680/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2017, 9:27 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8183
>     https://issues.apache.org/jira/browse/MESOS-8183
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `ContainerDaemon` class is responsible to monitor if a long-running
> service running in a standalone container, and restart the service
> container after it exits. It takes the following hook functions:
> 
> * `postStartHook`: called after the container is launched every time.
> * `postStopHook`: called after the container exits every time.
> 
> `ContainerDaemon` does not manage the lifecycle of the container it
> monitors, so the container persists across `ContainerDaemon`s.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 49dec55ced32945ad0414c32eb4e00247f4b54f2 
>   src/slave/container_daemon.hpp PRE-CREATION 
>   src/slave/container_daemon.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63680/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message