mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.
Date Thu, 16 Nov 2017 21:27:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63680/
-----------------------------------------------------------

(Updated Nov. 16, 2017, 9:27 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Joseph Wu.


Changes
-------

Addressed Joseph's comments.


Bugs: MESOS-8183
    https://issues.apache.org/jira/browse/MESOS-8183


Repository: mesos


Description (updated)
-------

The `ContainerDaemon` class is responsible to monitor if a long-running
service running in a standalone container, and restart the service
container after it exits. It takes the following hook functions:

* `postStartHook`: called after the container is launched every time.
* `postStopHook`: called after the container exits every time.

`ContainerDaemon` does not manage the lifecycle of the container it
monitors, so the container persists across `ContainerDaemon`s.


Diffs (updated)
-----

  src/Makefile.am 49dec55ced32945ad0414c32eb4e00247f4b54f2 
  src/slave/container_daemon.hpp PRE-CREATION 
  src/slave/container_daemon.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/63680/diff/5/

Changes: https://reviews.apache.org/r/63680/diff/4-5/


Testing
-------


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message