mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 63887: Fixed `wait()` and `destroy()` in composing containerizer.
Date Thu, 16 Nov 2017 20:42:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63887/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.


Bugs: MESOS-7506
    https://issues.apache.org/jira/browse/MESOS-7506


Repository: mesos


Description
-------

Previously, `wait()` and `destroy()` methods of composing containerizer
returned a future that might be set to `READY` state while the internal
state of composing containerizer is not yet cleaned up.

This patch adds a `termination` promise to `Container` struct,
which is used to return a future from `wait()` and `destroy()` methods.
This promise is set to `READY` state iff related container is
completely destroyed.
`_destroy()` callback is subscribed for a future from `wait()`, which is
called on related containerizer, to propagate a value to the
`termination` promise and do the cleanup.


Diffs
-----

  src/slave/containerizer/composing.cpp 64919ef1e61a984956c2280ae6b1890c4d135ad1 


Diff: https://reviews.apache.org/r/63887/diff/1/


Testing
-------

sudo make check
internal CI


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message