mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.
Date Thu, 16 Nov 2017 18:59:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63751/
-----------------------------------------------------------

(Updated Nov. 16, 2017, 7:59 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Fixed a race condition in the parameterized tests (Offers have to be sent out after `UpdateSlaveMessage`
was handled in the agent).


Bugs: MESOS-8211
    https://issues.apache.org/jira/browse/MESOS-8211


Repository: mesos


Description
-------

Agents the have the 'RESOURCE_PROVIDER' capability set, should get sent
'ApplyOfferOperationMessage' instead of 'CheckpointResourcesMessage'.
The agent will then figure out how to apply the operation. For agent
local resources the agent will checkpoint resources.


Diffs (updated)
-----

  src/common/protobuf_utils.hpp b2aa3654db2fe7d7d9d275ded81c6d54244654ee 
  src/common/protobuf_utils.cpp 34054846f93f19ba550afe58e2a899d111ad38dc 
  src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f 
  src/slave/slave.cpp d8edc5e6bbfa265bca4d19bbaa7db3063949dbc0 
  src/tests/persistent_volume_tests.cpp acfeac16884b00581a3523607ff26f44f6dca53a 
  src/tests/reservation_tests.cpp 470f7341686e69d0a71fb234a26b277c45c29780 


Diff: https://reviews.apache.org/r/63751/diff/5/

Changes: https://reviews.apache.org/r/63751/diff/4-5/


Testing
-------

make check


Thanks,

Jan Schlicht


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message