mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.
Date Thu, 16 Nov 2017 18:55:26 GMT


> On Nov. 16, 2017, 6:54 p.m., Avinash sridharan wrote:
> > src/checks/tcp_connect.cpp
> > Line 86 (original), 84 (patched)
> > <https://reviews.apache.org/r/63795/diff/2/?file=1894182#file1894182line86>
> >
> >     `AF_UNSPEC` is default. You can just do `net::IP::parse`
> >     
> >     Also instead of `parse` can we use `_ip`?

Looks like AlexR already vetoed the use of `_ip`, so I am good with that.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63795/#review191196
-----------------------------------------------------------


On Nov. 16, 2017, 7:21 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63795/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2017, 7:21 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Avinash sridharan.
> 
> 
> Bugs: MESOS-8050
>     https://issues.apache.org/jira/browse/MESOS-8050
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made `mesos-tcp-connect` support IPv6.
> 
> 
> Diffs
> -----
> 
>   src/checks/tcp_connect.cpp 2514f4aebcc634b18cd2b3c36529222fe456e903 
> 
> 
> Diff: https://reviews.apache.org/r/63795/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message