mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63861: Updated networking doc for Windows docker containers.
Date Thu, 16 Nov 2017 18:46:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/#review191218
-----------------------------------------------------------


Fix it, then Ship it!




Nit:

> Windows: Updated Docker networking documentation.

Add add a description (you can see what I mean about the title getting copied into the description).


docs/networking.md
Lines 118-123 (patched)
<https://reviews.apache.org/r/63861/#comment268882>

    Are the names of the network types on Windows generally capitalized (like the Linux ones
here are)?


- Andrew Schwartzmeyer


On Nov. 16, 2017, 10:18 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63861/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2017, 10:18 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
> 
> 
> Bugs: MESOS-7342
>     https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated networking doc for Windows docker containers.
> 
> 
> Diffs
> -----
> 
>   docs/networking.md bdd3a762435aae163fc659cc0000fea7da825983 
> 
> 
> Diff: https://reviews.apache.org/r/63861/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message