mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63860: Fixed docker network settings for Windows.
Date Thu, 16 Nov 2017 18:43:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63860/#review191217
-----------------------------------------------------------


Fix it, then Ship it!




Nit the review title (for consistency):
> Windows: Mapped the Docker network info types.


src/docker/docker.cpp
Lines 742-743 (original), 742-760 (patched)
<https://reviews.apache.org/r/63860/#comment268876>

    If there's an MSDN doc we can reference here to explain this mapping, that'd be great.



src/docker/docker.cpp
Lines 747-748 (patched)
<https://reviews.apache.org/r/63860/#comment268881>

    Nit: 'host' ... 'transparent' for consistency.



src/docker/docker.cpp
Lines 749 (patched)
<https://reviews.apache.org/r/63860/#comment268877>

    Nit: "'Host'..." and then no need to escape the double quotes ;)



src/docker/docker.cpp
Lines 756 (patched)
<https://reviews.apache.org/r/63860/#comment268879>

    Nit: 'bridge' ... 'nat' for consistency.


- Andrew Schwartzmeyer


On Nov. 16, 2017, 10:18 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63860/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2017, 10:18 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
> 
> 
> Bugs: MESOS-7342
>     https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The current Network enum in DockerInfo is specific to Linux containers.
> Instead of supporting {host, bridge, none, user} networks, Windows
> docker supports {nat, none, user} networks. Now, if the host network
> type is sent to the Windows agent, it will return an error. If the
> bridge network is sent, then it will be internally converted to nat,
> since they are equivalent.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 722a54ad113fc4e2bb22a8f08e307ab38d5fbfed 
> 
> 
> Diff: https://reviews.apache.org/r/63860/diff/1/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/63862/ for test results.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message