mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Review Request 63862: Ported docker_tests.cpp to Windows.
Date Thu, 16 Nov 2017 18:18:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer and John Kordich.


Bugs: MESOS-7342
    https://issues.apache.org/jira/browse/MESOS-7342


Repository: mesos


Description
-------

Ported the disabled tests to run on Windows. The following tests
could not be ported due to Windows platform limitations and were
simply #ifdef'd out:
  - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
    sandbox).
  - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
  - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).


Diffs (updated)
-----

  src/tests/containerizer/docker_tests.cpp 5cabf5a0b0164f9923008677c58806c8931cbc8d 


Diff: https://reviews.apache.org/r/63862/diff/1/


Testing (updated)
-------

Windows mesos-test:
[==========] 754 tests from 77 test cases ran. (270586 ms total)
[  PASSED  ] 754 tests.


Windows DockerTest only:
[==========] 11 tests from 1 test case ran. (85617 ms total)
[  PASSED  ] 11 tests.

Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
[==========] 12 tests from 1 test case ran. (12413 ms total)
[  PASSED  ] 12 tests.


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message