mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 60624: Enabled HDFS compilation and associated tests.
Date Thu, 16 Nov 2017 18:08:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60624/#review191202
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/hdfs_tests.cpp
Lines 55 (patched)
<https://reviews.apache.org/r/60624/#comment268852>

    Let's mark as a `TODO`.



src/tests/hdfs_tests.cpp
Lines 71 (patched)
<https://reviews.apache.org/r/60624/#comment268853>

    Let's mark these as `TODO`s here and below.


- Michael Park


On Nov. 6, 2017, 10:10 a.m., Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60624/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2017, 10:10 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, Li Li, and Michael
Park.
> 
> 
> Bugs: MESOS-6705
>     https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Note that HDFS tests are disabled for Windows due to dependence on
> 'sh' shell.
> 
> Be aware: HDFS hasn't been tested, although it should work. We will
> formally add support for HDFS at a later date, see MESOS-5460.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 219252f6f82b2d62d024b2ab876fa0ba2f5c8e6c 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/hdfs_tests.cpp e7154c75e663d9a98bec48be42a59b65c96f9515 
> 
> 
> Diff: https://reviews.apache.org/r/60624/diff/6/
> 
> 
> Testing
> -------
> 
> See upstream
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message