mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 63794: Added a new member field `ipv6` to the `CheckerProcess` class.
Date Thu, 16 Nov 2017 07:20:52 GMT


> On Nov. 16, 2017, 8:49 a.m., Alexander Rukletsov wrote:
> > src/checks/health_checker.cpp
> > Lines 266-273 (patched)
> > <https://reviews.apache.org/r/63794/diff/1/?file=1891630#file1891630line266>
> >
> >     Hm, maybe this is more readable?
> >     ```
> >       if ((healthCheck.type() == HealthCheck.HTTP &&
> >            healthCheck.http().protocol() == NetworkInfo::IPv6) ||
> >           (healthCheck.type() == HealthCheck.TCP &&
> >            healthCheck.tcp().protocol() == NetworkInfo::IPv6)) {
> >         ipv6 = true;
> >       }
> >     ```

Agree!


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63794/#review191127
-----------------------------------------------------------


On Nov. 16, 2017, 3:20 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63794/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2017, 3:20 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Avinash sridharan.
> 
> 
> Bugs: MESOS-8050
>     https://issues.apache.org/jira/browse/MESOS-8050
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a new member field `ipv6` to the `CheckerProcess` class.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker_process.hpp 5d0c36dd3e1edf68527fc109d8c0708f09b7e12f 
>   src/checks/checker_process.cpp 7985e8d4dc6115f81a4daef0ce4eee67f4233c9f 
>   src/checks/health_checker.cpp d4bda6ed1747ae4c970619bbfa336321aeea52ea 
> 
> 
> Diff: https://reviews.apache.org/r/63794/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message