mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 60620: Modifed os::write to write binary files on Windows.
Date Wed, 15 Nov 2017 23:34:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60620/#review191121
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Nov. 6, 2017, 10:11 a.m., Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60620/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2017, 10:11 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, Li Li, and Michael
Park.
> 
> 
> Bugs: MESOS-6705
>     https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> By default, ::write operations on Windows will include a \r\n (CR/LF)
> at the end of each line, which is not compatible with Linux. Mesos
> expects only \n (LF) characters between lines.
> 
> This commit will modify Windows behavior to only include \n at the
> end of each line written to a text file.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/write.hpp 9ff749f209e6dd6ca3695907108a029c9a2b4f05

> 
> 
> Diff: https://reviews.apache.org/r/60620/diff/7/
> 
> 
> Testing
> -------
> 
> Built successfully on both Linux (with autotools and cmake) and Windows (with cmake).
> 
> Ran stout-tests and mesos-tests successfully on both Windows and Linux.
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message