mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 63639: Enabled rvalue reference parameters in protobuf handlers.
Date Wed, 15 Nov 2017 22:21:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63639/#review191115
-----------------------------------------------------------


Ship it!





3rdparty/libprocess/include/process/protobuf.hpp
Lines 143-145 (patched)
<https://reviews.apache.org/r/63639/#comment268703>

    As a separate change, it looks like allocating an M is not necessary, AFAICT
    
    ```
    M::descriptor()->full_name()
    ```
    
    is equivalent to
    
    ```
    google::protobuf::Message* m = new M();
    m->GetTypeName()
    ```


- Benjamin Mahler


On Nov. 7, 2017, 4:52 p.m., Dmitry Zhuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63639/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2017, 4:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Bugs: MESOS-6972
>     https://issues.apache.org/jira/browse/MESOS-6972
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using rvalue reference parameter in protobuf handler opts-out of arena
> usage, and allows moving message further in dispatch chain.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/protobuf.hpp fe152f273332470ac50f9715291897bb04cf95b9

> 
> 
> Diff: https://reviews.apache.org/r/63639/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dmitry Zhuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message