mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Kordich via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 63810: Windows: Added internal `fullpath` API to normalize paths.
Date Wed, 15 Nov 2017 20:38:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63810/#review191094
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
Lines 178 (patched)
<https://reviews.apache.org/r/63810/#comment268687>

    I've seen this function "stringify" before, but I don't have any context about it. Does
it convert from wide string to UTF-8?  Do we need to worry about non-ascii paths?


- John Kordich


On Nov. 14, 2017, 11:14 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63810/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2017, 11:14 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-6735
>     https://issues.apache.org/jira/browse/MESOS-6735
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This explicitly does not check for existence, nor does it follow
> symlinks. It simply normalizes a given path to an absolute path. This
> removes the `reparsepoint.hpp` and `symlink.hpp` dependency os
> `os::realpath`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp e3d04480cf793482d958ea9571d96a29b6bf09b1

>   3rdparty/stout/include/stout/internal/windows/symlink.hpp b9cf1229ec0b6c70fe9b9d358e867e91e475dfaa

>   3rdparty/stout/include/stout/windows/fs.hpp d7b883ca1f3f8972e1bf9fbd211cc564c7c30f14

> 
> 
> Diff: https://reviews.apache.org/r/63810/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message