mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63818: Added quick start instructions for CMake.
Date Wed, 15 Nov 2017 18:27:02 GMT


> On Nov. 14, 2017, 5:40 p.m., Gaston Kleiman wrote:
> > docs/cmake.md
> > Lines 43 (patched)
> > <https://reviews.apache.org/r/63818/diff/1/?file=1892196#file1892196line43>
> >
> >     I had to look up how to pass more parameters to make in order to use more threads:
> >     
> >     `cmake --build . -- -j 4`
> >     
> >     It might be useful to mention that here =).

Oh yeah, that's a good point. I usually run `-- /m` on Windows. I'll add it.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63818/#review191023
-----------------------------------------------------------


On Nov. 14, 2017, 3:12 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63818/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2017, 3:12 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added quick start instructions for CMake.
> 
> 
> Diffs
> -----
> 
>   docs/cmake.md b8f9e7caa84372404256767a0220ac1df9db8bc8 
> 
> 
> Diff: https://reviews.apache.org/r/63818/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message