mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 63732: Reconciled offer operations between agent and master.
Date Wed, 15 Nov 2017 17:31:21 GMT


> On Nov. 14, 2017, 4:14 p.m., Jan Schlicht wrote:
> > src/master/master.cpp
> > Lines 7093 (patched)
> > <https://reviews.apache.org/r/63732/diff/1/?file=1888504#file1888504line7093>
> >
> >     This needs to handle the case where the master might have offer operations that
the agent doesn't report here, e.g. after an agent failover. We should send operation feedback
to frameworks in that case, indicating an error with the operation. Otherwise frameworks will
receive no feedback for these operations.

For now I added a `TODO` to that effect here and in the agent code.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63732/#review190952
-----------------------------------------------------------


On Nov. 15, 2017, 6:31 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63732/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2017, 6:31 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8207
>     https://issues.apache.org/jira/browse/MESOS-8207
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 59a533940736f5cfd5ec31e0ed924f0b2ab13f9c 
> 
> 
> Diff: https://reviews.apache.org/r/63732/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`, still need to implement dedicated tests.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message