mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 63675: Added a non-allocating variant of `os::clone`.
Date Wed, 15 Nov 2017 11:59:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63675/#review191051
-----------------------------------------------------------


Ship it!




Ship It!

- Andrei Budnik


On Nov. 14, 2017, 7:06 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63675/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2017, 7:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8159
>     https://issues.apache.org/jira/browse/MESOS-8159
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a non-allocating variant of `os::clone` in the
> `os::signal_safe` namespace. This encapsulates the lambda
> trampoline, but requires the caller to bring their own stack
> since we can't know when it is safe to implicitly allocate
> a stack.
> 
> Now that we have `os::signal_safe::clone`, there is no need for
> `os::clone` to take an optional `os::Stack` argument. We can
> remove that and simplify the cleanup logic.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/linux.hpp 68b4090aa5e6f23609c487128d91301755ae0e46

> 
> 
> Diff: https://reviews.apache.org/r/63675/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message