mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 63801: Windows: Fixed build of Google Test with Visual Studio Preview.
Date Wed, 15 Nov 2017 05:17:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63801/#review191032
-----------------------------------------------------------



PASS: Mesos patch 63801 was successfully built and tested.

Reviews applied: `['63801']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63801

- Mesos Reviewbot Windows


On Nov. 14, 2017, 6:47 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63801/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2017, 6:47 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, John Kordich, and James Peach.
> 
> 
> Bugs: MESOS-8220
>     https://issues.apache.org/jira/browse/MESOS-8220
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The preview version of Visual Studio (15.5) adds a new deprecation
> warning that Google Test emits. Google Test is also built with
> `-Werror`, and thus fails to build unless this warning is silenced.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 7d38a9cba84b86e1e428033ade1bd0ab5d9eaae7 
> 
> 
> Diff: https://reviews.apache.org/r/63801/diff/3/
> 
> 
> Testing
> -------
> 
> Been building with this patch on Windows with the Preview version of Visual Studio since
last week.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message