mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 63652: Added d_type check in containerizer backend validation.
Date Tue, 14 Nov 2017 21:30:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63652/
-----------------------------------------------------------

(Updated Nov. 14, 2017, 1:30 p.m.)


Review request for mesos, Gilbert Song and James Peach.


Bugs: MESOS-8121
    https://issues.apache.org/jira/browse/MESOS-8121


Repository: mesos


Description
-------

In unified containerizer, the d_type cannot be 1
if we are using the overlay fs backend.
Raise error if user specifies overlayfs as backend.
Fallback to other backends in the default case and
raise a warning.


Diffs (updated)
-----

  src/linux/fs.hpp cbc8bf79083ce2bc34fa698808eaf92764a577a9 
  src/linux/fs.cpp 40c31a3ad2ccbeb59868c5e2d7b1809c613da8de 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 450a3b32d69d2882973a6ed4e94e169a0256056b



Diff: https://reviews.apache.org/r/63652/diff/4/

Changes: https://reviews.apache.org/r/63652/diff/3-4/


Testing
-------

Manually tested slave creation with default and overlayfs backends on XFS based work_dir with
different ftype mount options.


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message