mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitry Zhuk <dz...@twopensource.com>
Subject Re: Review Request 63753: Upgraded vendored protobuf to 3.5.0.
Date Tue, 14 Nov 2017 20:57:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63753/
-----------------------------------------------------------

(Updated Nov. 14, 2017, 8:57 p.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-8139
    https://issues.apache.org/jira/browse/MESOS-8139


Repository: mesos


Description
-------

Version 3.4 adds and version 3.5 improves move support in generated
C++ code.
`protobuf-3.5.0.tar.gz` was built using the script:
```
curl -L -O https://github.com/google/protobuf/archive/v3.5.0.tar.gz
tar -xzf v3.5.0.tar.gz
cd protobuf-3.5.0
./autogen.sh
cd ..
tar -czf protobuf-3.5.0.tar.gz protobuf-3.5.0
```


Diffs (updated)
-----

  3rdparty/cmake/Versions.cmake da2d837e327535c793f20929e8c6e9ddaf5ca54a 
  3rdparty/protobuf-3.3.0.tar.gz 98fbec86484032753c4022b4519ec40243e4e951 
  3rdparty/protobuf-3.5.0.tar.gz PRE-CREATION 
  3rdparty/versions.am 2fc2f2c3932ff86c348d954bd4d78aa5c75bb052 
  LICENSE 1327411d038dfbda5a8324290469707ae02a4aa3 
  configure.ac 067005e1be3a09e8320be120c8784f195e30ac5d 
  src/CMakeLists.txt b0e223121f24ac0dc604dc2c639158b817eec535 
  src/java/mesos.pom.in 56428832820efccd72d302d1b2cf1b3a4554960b 
  src/python/interface/setup.py.in abf160c9741f61a37f5a0fe3f5fc64bbddc02142 
  src/python/native_common/ext_modules.py.in 39e0faad414f2c826dacfe1302106f2d5e7c8967 
  src/python/protocol/setup.py.in 0fa0c1724bd39ab573e14a9137e4e3fe517c9c93 
  support/mesos-tidy/entrypoint.sh dbea146a882510bda4e5868d8c2ced2e97a36d83 


Diff: https://reviews.apache.org/r/63753/diff/3/

Changes: https://reviews.apache.org/r/63753/diff/2-3/


Testing
-------

make check

cmake --build .


Thanks,

Dmitry Zhuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message