mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <>
Subject Re: Review Request 63677: Changed `os:Stack` to allocate with `mmap`.
Date Tue, 14 Nov 2017 19:11:27 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 14, 2017, 7:11 p.m.)

Review request for mesos, Benjamin Bannier and Jie Yu.

Bugs: MESOS-8159

Repository: mesos


If `os:Stack` is allocated with `mmap`, this automatically
guarantees the correct alignment (since `mmap` is page-aligned
by definition).

Although `mmap` is not required to be async signal safe
(i.e. it might not be safe to call from a signal handler), in
practice it should be safe to call between `fork` and `exec`
since it is a raw system call that does not require any user
space locks to be held.

Diffs (updated)

  3rdparty/stout/include/stout/os/linux.hpp 68b4090aa5e6f23609c487128d91301755ae0e46 




sudo make check (Fedora 26)


James Peach

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message