mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63798: Added resource provider support for all offer operations.
Date Tue, 14 Nov 2017 18:27:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63798/#review190974
-----------------------------------------------------------




src/slave/slave.cpp
Lines 3756-3765 (patched)
<https://reviews.apache.org/r/63798/#comment268566>

    Hum, looks like this is common for both agent default resources or resource provider resources.
Can we do that in `addOfferOperation` (like we did in the master)?
    
    Then, that'll break the following code for agent default resources :( Maybe it's better
to just not re-use the same `checkpointResources` handler?
    
    Please do more thinking here.


- Jie Yu


On Nov. 14, 2017, 2:11 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63798/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2017, 2:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8218
>     https://issues.apache.org/jira/browse/MESOS-8218
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `RESERVE`/`UNRESERVE`/`CREATE`/`DESTROY` operations for
> reservations and persistent volumes have been enabled for resource
> provider resources. Similar to agent resources, they are speculatively
> applied to allow offer pipelining.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp d8bacebc74790e955490a158c37ac0d9e75fd6b5 
>   src/tests/resource_provider_manager_tests.cpp ecfe2b4c0952838d6312df603f8eb2f458725175

> 
> 
> Diff: https://reviews.apache.org/r/63798/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message