mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63801: Windows: Fixed build of Google Test with Visual Studio Preview.
Date Tue, 14 Nov 2017 18:14:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63801/
-----------------------------------------------------------

(Updated Nov. 14, 2017, 10:14 a.m.)


Review request for mesos, Akash Gupta, John Kordich, and James Peach.


Changes
-------

Moved into Windows section.


Bugs: MESOS-8220
    https://issues.apache.org/jira/browse/MESOS-8220


Repository: mesos


Description
-------

The preview version of Visual Studio (15.5) adds a new deprecation
warning that Google Test emits. Google Test is also built with
`-Werror`, and thus fails to build unless this warning is silenced.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt 7d38a9cba84b86e1e428033ade1bd0ab5d9eaae7 


Diff: https://reviews.apache.org/r/63801/diff/2/

Changes: https://reviews.apache.org/r/63801/diff/1-2/


Testing
-------

Been building with this patch on Windows with the Preview version of Visual Studio since last
week.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message