mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 63728: Fix IoSwitchboard tests.
Date Mon, 13 Nov 2017 18:26:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63728/#review190853
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/io_switchboard_tests.cpp
Line 1104 (original), 1115 (patched)
<https://reviews.apache.org/r/63728/#comment268423>

    It is not clear that this comment is related to the next two blocks in a whole.


- Alexander Rukletsov


On Nov. 13, 2017, 4:24 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63728/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2017, 4:24 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix IoSwitchboard tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/io_switchboard_tests.cpp 0828119f88e3d74a48f904b9aeb6b401c1766e8d

> 
> 
> Diff: https://reviews.apache.org/r/63728/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo ./src/mesos-tests --gtest_filter="*IOSwitchboard*"`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message