mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitry Zhuk <dz...@twopensource.com>
Subject Review Request 63761: Replaced std::shared_ptr with std::unique_ptr in dispatch.
Date Mon, 13 Nov 2017 17:02:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63761/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Michael Park.


Bugs: MESOS-6972
    https://issues.apache.org/jira/browse/MESOS-6972


Repository: mesos


Description
-------

Since `dispatch` can now handle movable only parameters, `Promise` and
functor can be safely wrapped into `std::unique_ptr` for efficiency.


Diffs
-----

  3rdparty/libprocess/include/process/dispatch.hpp 096cae037aec29059e1f13ac467bffe94ecd14ba

  3rdparty/libprocess/include/process/event.hpp 2e246205020c3c5b8c2eb5187a8eb3643d1e6d4d 
  3rdparty/libprocess/src/process.cpp 71ae7129ffbd0e22eda2863b17bbcf588298c37b 


Diff: https://reviews.apache.org/r/63761/diff/1/


Testing
-------

make check


Thanks,

Dmitry Zhuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message